sb/ACC-System
1
0
Fork 0
Code Issues Pull requests Projects Releases 2 Packages Wiki Activity Actions

Rename ONEDRIVE_SYNC_PATH/ONEDRIVE_PHOTOS_PATH env vars #4

Merged
sb merged 1 commit from rename-onedrive-sync-path into main 2026-08-09 08:59:13 +10:00
Conversation 0 Commits 1 Files changed 10 +22 -14
sb commented 2026-08-09 08:52:24 +10:00
Owner
Copy link

Renamed two environment variables so their names describe what the app stores there rather than the sync mechanism behind it:

  • ONEDRIVE_SYNC_PATH → BOOKING_PDF_PATH
  • ONEDRIVE_PHOTOS_PATH → UPLOADED_PHOTOS_PATH

Updated every source usage (pdf-bookings.ts, booking-date.ts, booking-sheet/route.ts, chauffeur/booking-sheet/[id]/route.ts, chauffeur/upload-photos/route.ts — including the user-facing "not configured" error string) and both docs (environment-variables.md, onedrive-sync.md). Left CHANGELOG.md's historical entries untouched, as those correctly describe what the variable was called at the time.

Action required on deploy: rename both variables in production .env. Both features no-op silently when their variable is unset, so this won't error loudly — booking-PDF generation and chauffeur photo uploads would just quietly stop working.

Verified: build/lint clean, 199/199 tests passing (no logic changed, just the variable name), and confirmed live in a running dev server that a booking save picks up BOOKING_PDF_PATH and writes both PDFs correctly.

Renamed two environment variables so their names describe what the app stores there rather than the sync mechanism behind it: - `ONEDRIVE_SYNC_PATH` → `BOOKING_PDF_PATH` - `ONEDRIVE_PHOTOS_PATH` → `UPLOADED_PHOTOS_PATH` Updated every source usage (`pdf-bookings.ts`, `booking-date.ts`, `booking-sheet/route.ts`, `chauffeur/booking-sheet/[id]/route.ts`, `chauffeur/upload-photos/route.ts` — including the user-facing "not configured" error string) and both docs (`environment-variables.md`, `onedrive-sync.md`). Left `CHANGELOG.md`'s historical entries untouched, as those correctly describe what the variable was called at the time. **Action required on deploy:** rename both variables in production `.env`. Both features no-op silently when their variable is unset, so this won't error loudly — booking-PDF generation and chauffeur photo uploads would just quietly stop working. Verified: build/lint clean, 199/199 tests passing (no logic changed, just the variable name), and confirmed live in a running dev server that a booking save picks up `BOOKING_PDF_PATH` and writes both PDFs correctly.
ONEDRIVE_SYNC_PATH -> BOOKING_PDF_PATH, ONEDRIVE_PHOTOS_PATH ->
UPLOADED_PHOTOS_PATH. The names now describe what the app stores
there rather than the sync mechanism behind it.

Production .env files need both variables renamed on deploy, or
booking-PDF generation and chauffeur photo uploads silently stop
(both no-op when their variable is unset).
sb merged commit f32a7b4852 into main 2026-08-09 08:59:13 +10:00
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels
No items
No labels
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
sb/ACC-System!4
No description provided.